Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: manifest.json support #236

Merged
merged 7 commits into from
May 21, 2018
Merged

feat: manifest.json support #236

merged 7 commits into from
May 21, 2018

Conversation

fent
Copy link
Contributor

@fent fent commented Mar 4, 2018

Hi there,

I've added support for updating a manifest.json file, which is used in Google Chrome extensions.
There's potential in standard-release to be used for software packages that are not node.js related or don't use npm. And I think this is a good start towards that.

Thank you for this tool btw, it's helped me a lot!

@stevemao
Copy link
Member

stevemao commented Mar 5, 2018

I guess we could merge this before we come up with a plugin strategy?

@fent
Copy link
Contributor Author

fent commented Mar 6, 2018

Just noticed I left the .only on the test. But now some other tests fail.

Will try to figure out why.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 99.853% when pulling 4a030cd on fent:manifest into 9a99607 on conventional-changelog:master.

@coveralls
Copy link

coveralls commented Mar 11, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling afd1620 on fent:manifest into 9a99607 on conventional-changelog:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 99.853% when pulling 4a030cd on fent:manifest into 9a99607 on conventional-changelog:master.

@bcoe
Copy link
Member

bcoe commented May 21, 2018

@fent I like this refactor.

@bcoe bcoe merged commit 371d992 into conventional-changelog:master May 21, 2018
@fent fent deleted the manifest branch May 21, 2018 18:06
@bcoe
Copy link
Member

bcoe commented May 21, 2018

@fent please try, npm i standard-version@next it should have your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants