Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(is-ignored): ignore reapply commits #4186

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

risu729
Copy link
Contributor

@risu729 risu729 commented Oct 24, 2024

In Git 2.43, the double-revert commits have commit messages starting with Reapply.
This PR ignores Reapply commits by default.

https://github.blog/open-source/git/highlights-from-git-2-43/#split-repositories-with-object-filters:~:text=HEAD%20%2D%3E%20main)-,Reapply,-%22fix%20bug%22

Copy link

codesandbox-ci bot commented Oct 24, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@escapedcat
Copy link
Member

Thanks!
Maybe this is a feature? Sounds like we never supported this, but now we do? wdyt?

You wanna adjust the commit scope to is-ignored?

scope must be one of [commitlint-config-patternplate, commitlint-config-nx-scopes, commitlint-config-lerna-scopes, commitlint-config-angular, commitlint, types, travis-cli, top-level, to-lines, rules, resolve-extends, read, prompt-cli, prompt, parse, message, load, lint, is-ignored, format, execute-rule, ensure, cz-commitlint, core, config-validator, config-rush-scopes, config-pnpm-scopes, config-patternplate, config-nx-scopes, config-lerna-scopes, config-conventional, config-angular-type-enum, config-angular, cli, utils, vitest-environment-commitlint, test] [scope-enum]

@risu729 risu729 changed the title fix(is_ignored): ignore reapply commits fix(is-ignored): ignore reapply commits Oct 24, 2024
@risu729 risu729 changed the title fix(is-ignored): ignore reapply commits feat(is-ignored): ignore reapply commits Oct 24, 2024
@risu729
Copy link
Contributor Author

risu729 commented Oct 24, 2024

Oh, sorry for the wrong scope. I fixed it.
I agree this is a new feature, so I also updated the type.

@escapedcat
Copy link
Member

Awesome, thanks! Will merge

@escapedcat escapedcat merged commit 49ba56d into conventional-changelog:master Oct 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants