Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add repository directory for all packages.json #2812

Merged
merged 1 commit into from
Oct 13, 2021
Merged

chore: add repository directory for all packages.json #2812

merged 1 commit into from
Oct 13, 2021

Conversation

iamandrewluca
Copy link
Contributor

If the package.json for your package is not in the root directory (for example if it is part of a monorepo), you can specify the directory in which it lives:

"repository": {
  "type" : "git",
  "url" : "https://github.com/facebook/react.git",
  "directory": "packages/react-dom"
}

https://docs.npmjs.com/cli/v6/configuring-npm/package-json#repository

I use a lot https://njt.vercel.app/ to jump to different packages information,
and with this PR we can know exactly what package in what folder lives

Made the changes with a script to make it easier 🙂

https://gist.github.com/iamandrewluca/5cc85b56a595056f0099d04ed6dd8a79

@escapedcat
Copy link
Member

Hey @iamandrewluca , thanks!
If it makes your life easier let's add it. I don't understand why you used the [skip ci] in your commit though? Should be fine to let it run, no?

@iamandrewluca
Copy link
Contributor Author

Hey @escapedcat

I have a template for this type of PR, and [skip ci] was part of it.
I thought there is no need to run CI for a chore.

I will ammend commit and remove skip ci

> If the package.json for your package is not in the root directory (for example if it is part of a monorepo), you can specify the directory in which it lives:
> ```json
> "repository": {
>   "type" : "git",
>   "url" : "https://github.com/facebook/react.git",
>   "directory": "packages/react-dom"
> }
> ```
> — https://docs.npmjs.com/cli/v6/configuring-npm/package-json#repository

I use a lot https://njt.vercel.app/ to jump to different packages information,
and with this PR we can know exactly what package in what folder lives

Made the changes with a script to make it easier 🙂

https://gist.github.com/iamandrewluca/5cc85b56a595056f0099d04ed6dd8a79
@iamandrewluca iamandrewluca changed the title chore: add repository directory for all packages.json [skip ci] chore: add repository directory for all packages.json Oct 13, 2021
@escapedcat
Copy link
Member

Thanks @iamandrewluca , on other project we also use ci skip, but in this case I feel much more comfortable to merge something in when all checks are green. Even if it's just a chore or docs change ;)

@escapedcat escapedcat merged commit e7e9a65 into conventional-changelog:master Oct 13, 2021
@iamandrewluca iamandrewluca deleted the package-json-repository-directory branch October 13, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants