Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add codemagic-ci info #2760

Merged
merged 2 commits into from
Sep 22, 2021

Conversation

K-Codemagic
Copy link
Contributor

docs: add codemagic-ci info

docs: add codemagic-ci info

Description

Motivation and Context

Usage examples

// commitlint.config.js
module.exports = {};
echo "your commit message here" | commitlint # fails/passes

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x ] My change requires a change to the documentation.
  • [ x] I have updated the documentation accordingly.
  • [x ] I have added tests to cover my changes.
  • [x ] All new and existing tests passed.

docs: add codemagic-ci info
@K-Codemagic
Copy link
Contributor Author

Any update on this!?

@@ -75,4 +75,15 @@ workflows:
- lint_commit_message: { requires: [setup] }
```

## [Codemagic](https://codemagic.io/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked to the other member about this. Would please change it in this way:

### 3rd party integrations

#### [Codemagic](https://codemagic.io/)

We want to avoid that people reporting bugs about this in the future and expect us to fix this.
Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it is same as Travis and CircleCI, then why such changes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because for now we maintain support for these. For codemagic we will not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@escapedcat
Copy link
Member

Thanks @K-Codemagic

@escapedcat escapedcat merged commit ae87788 into conventional-changelog:master Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants