Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get-sdtin dependency #2557

Merged
merged 2 commits into from
Apr 24, 2021

Conversation

AdeAttwood
Copy link
Member

As in #2552 the package get-stdin has moved to an ESM package. Reading their upgrade guide It looks like to use that you will need to move to an ESM package to use get-stdin. This removes the dependency and implements the one function in cli.ts.

This function is only being used once and only one function. I think this is a good way to go with minimal overhead.

Let me know what you think

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

renovate-bot and others added 2 commits April 16, 2021 10:42
The get-stdin package has now gone to ESM and can not be used by
common js package. This removes the dependency and implements the
package.
@escapedcat
Copy link
Member

Thanks @AdeAttwood !
Yeah, would be ok to just get rid of the dependency.
Let me ask for feedback and get back to you.

Out of curiosity, do you you know how to get it work with v9? Just wondering what I missed in #2552

@AdeAttwood
Copy link
Member Author

Out of curiosity, do you you know how to get it work with v9?

The short answer is no, however like you feel I am missing something.

From reading this that is linked in the release notes. My understanding is the options are to move commitlint to ESM or stay on the previous version of get-stdin.

Disclaimer: I have just started looking / contributing to the project after using the tool for some time so take my input lightly.

Moving commitlint to ESM seems to be the way to go however a bit drastic to get this dependency to work especially with the "Move to typescript" ticket still open. I have not looked into moving to ESM very much but from the upgrade of get-stdin it would have to be in the next major version.

@escapedcat escapedcat merged commit 597cb59 into conventional-changelog:master Apr 24, 2021
@escapedcat
Copy link
Member

@AdeAttwood thanks! If you are interested you can join our slack: https://devtoolscommunity.herokuapp.com/
There's a #commitlint channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants