feat(prompt): rewrite codebase to use inquirer #2375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armano2
changed the title
armano2
force-pushed
the
refactor/prompt2
branch
2 times, most recently
from
beb2ec0
to
8674c0a
Compare
armano2
force-pushed
the
refactor/prompt2
branch
from
8674c0a
to
8d7f369
Compare
armano2
force-pushed
the
refactor/prompt2
branch
from
8d7f369
to
02179c8
Compare
armano2
commented
Jan 9, 2021
| @@ -0,0 +1,55 @@ | |||
| import {Result} from './types'; | |||
| import format from './format'; | |||
There was a problem hiding this comment.
i added some additional tests here, as this file was never tested
armano2
commented
Jan 9, 2021
| }); | ||
| const message = await input(prompt); | ||
| expect(message).toEqual('fix(test): subject\n' + 'body\n' + 'footer'); | ||
| }); |
There was a problem hiding this comment.
those tests actually test validation only, as there is no viable / easy way to write proper end to end tests
most likely we should add more cases here
armano2
commented
Jan 9, 2021
armano2
commented
Jan 9, 2021
armano2
force-pushed
the
refactor/prompt2
branch
from
dcaa7a4
to
1ca392c
Compare
armano2
commented
Jan 12, 2021
| @@ -0,0 +1,96 @@ | |||
| import {Answers, PromptModule, QuestionCollection} from 'inquirer'; | |||
| /// <reference path="./inquirer/inquirer.d.ts" /> | |||
There was a problem hiding this comment.
if you have better idea for this, I'm open to suggestions
This was referenced Jul 29, 2021
|
Updated and merged via #2697 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is highly experimental, and most likely requires more refining
Description
Current implementation of prompt is using vorpal that is using outdated version inquirer,
before merging this some of changes and tests can be submitted separately.Motivation and Context
fixes #46, closes #86, fixes #402, fixes #585, fixes #688, fixes #812, fixes #1531
How Has This Been Tested?
New and exsiting tests and manual tests
Types of changes
Checklist: