-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prompt): rewrite codebase to use inquirer #2375
Conversation
beb2ec0
to
8674c0a
Compare
8674c0a
to
8d7f369
Compare
8d7f369
to
02179c8
Compare
@@ -0,0 +1,55 @@ | |||
import {Result} from './types'; | |||
import format from './format'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i added some additional tests here, as this file was never tested
}); | ||
const message = await input(prompt); | ||
expect(message).toEqual('fix(test): subject\n' + 'body\n' + 'footer'); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those tests actually test validation only, as there is no viable / easy way to write proper end to end tests
most likely we should add more cases here
dcaa7a4
to
1ca392c
Compare
@@ -0,0 +1,96 @@ | |||
import {Answers, PromptModule, QuestionCollection} from 'inquirer'; | |||
/// <reference path="./inquirer/inquirer.d.ts" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you have better idea for this, I'm open to suggestions
Updated and merged via #2697 🎉 |
This is highly experimental, and most likely requires more refining
Description
Current implementation of prompt is using vorpal that is using outdated version inquirer,
before merging this some of changes and tests can be submitted separately.Motivation and Context
fixes #46, closes #86, fixes #402, fixes #585, fixes #688, fixes #812, fixes #1531
How Has This Been Tested?
New and exsiting tests and manual tests
Types of changes
Checklist: