-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Has the default configuration of scope-case changed? #3157
Comments
Yeah, looks like it. Have a look at:
I guess the README needs to be updated. Wanna create a PR for that? |
@escapedcat Sure, my pleasure. I referenced to the #828. The pr modified @commitlint/config-conventional/index.js. Verification of |
@escapedcat In addition, I found that the docs/reference-rules.md also contains the description of |
Sorry for the late reply.
Let's start with this. I think it would be good clear this up.
I believe this is ok. conventional commits doens't define the scope case. Maybe angular does? I don't know tbh. But at least it's ok that they are not the same. |
When the contents of the
commitlint.config.js
are as follows:I ran this command
Expected Behavior
According to the content here: https://commitlint.js.org/#/reference-rules, the
scope-case
default value islowerCase
. This commit should be aborted.Current Behavior
But in fact, this message passed the verification. And here are my commit logs:
Possible Solution
I added the configuration of the rules, as follows:
Then I commit with a same message, this time it's aborted.
Your Environment
@commitlint/config-conventional --version
@commitlint/cli --version
git --version
node --version
The text was updated successfully, but these errors were encountered: