Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Docker Service for Goss Tests #278

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Enable Docker Service for Goss Tests #278

merged 1 commit into from
Aug 5, 2020

Conversation

s-irvine
Copy link
Contributor

@s-irvine s-irvine commented Aug 5, 2020

  • Please check if the PR fulfills these requirements
  • The commit message follows the conventional commits guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Fixes #270 with a minor update to enable the Docker service on the hosts.

@s-irvine s-irvine added bug Something isn't working. low Low effort to resolve. terraform terraform work labels Aug 5, 2020
@s-irvine s-irvine requested a review from jondkent as a code owner August 5, 2020 14:37
@pi-unnerup pi-unnerup self-requested a review August 5, 2020 14:50
pi-unnerup
pi-unnerup reviewed Aug 5, 2020
View reviewed changes
Copy link
Contributor

@pi-unnerup pi-unnerup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pi-unnerup pi-unnerup requested review from pi-unnerup and removed request for jondkent August 5, 2020 14:51
@pi-unnerup pi-unnerup merged commit 121729e into master Aug 5, 2020
@s-irvine s-irvine deleted the fix-docker-service-test branch August 5, 2020 15:12
@isleo2 isleo2 mentioned this pull request Apr 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi-unnerup pi-unnerup pi-unnerup approved these changes

Assignees
No one assigned
Labels
bug Something isn't working. low Low effort to resolve. terraform terraform work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix failing docker goss tests
2 participants
@s-irvine @pi-unnerup