Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow extra ips to be added to the bastion sg #225

Merged
merged 2 commits into from
Feb 25, 2020
Merged

Conversation

s-irvine
Copy link
Contributor

Users can now specify CIDRs to be added to the bastion security group with the --extra-cidrs flag.

Resolves #164

@s-irvine s-irvine added enhancement New feature or request. medium Medium effort/code change. terraform terraform work go labels Feb 14, 2020
@jondkent
Copy link
Contributor

Reviewing

Copy link
Contributor

@abdullahgarcia abdullahgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jondkent jondkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raoulmillais
Copy link
Contributor

This is great how about making IP detection optional entirely?

@pi-unnerup
Copy link
Contributor

I can not make this work. To replicate try

  • create infra on workspace network with -e /32 where ip is your ip on the second network
  • simulator ssh attack on new network (I have tried both dot11 in workspace and android)

@pi-unnerup
Copy link
Contributor

This is great how about making IP detection optional entirely?

#232 made a ticket here

@s-irvine
Copy link
Contributor Author

I can not make this work. To replicate try

  • create infra on workspace network with -e /32 where ip is your ip on the second network
  • simulator ssh attack on new network (I have tried both dot11 in workspace and android)

I've managed to replicate the issue and I think it's to do with the IP detection breaking. The SSH command is not actually run because IP detection fails before it gets there. I think #232 will fix this issue by allowing us to disable IP detection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. go medium Medium effort/code change. terraform terraform work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add arbitrary IPs to the Simulator Security Groups
5 participants