-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow extra ips to be added to the bastion sg #225
Conversation
Reviewing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is great how about making IP detection optional entirely? |
I can not make this work. To replicate try
|
#232 made a ticket here |
I've managed to replicate the issue and I think it's to do with the IP detection breaking. The SSH command is not actually run because IP detection fails before it gets there. I think #232 will fix this issue by allowing us to disable IP detection. |
Users can now specify CIDRs to be added to the bastion security group with the
--extra-cidrs
flag.Resolves #164