Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused IS_TEST_ONLY variable and various test #128

Merged
merged 1 commit into from
Dec 2, 2019
Merged

Removed unused IS_TEST_ONLY variable and various test #128

merged 1 commit into from
Dec 2, 2019

Conversation

jondkent
Copy link
Contributor

@jondkent jondkent commented Dec 2, 2019

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Start of refactoring :)

  • Other information:

Remove IS_TEST_ONLY variable as unused by simulator and is of limited use as presently implemented

@jondkent jondkent requested a review from a team as a code owner December 2, 2019 15:55
@jondkent jondkent removed the request for review from a team December 2, 2019 15:55
abdullahgarcia
abdullahgarcia approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@abdullahgarcia abdullahgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jondkent jondkent merged commit feeb51c into master Dec 2, 2019
@jondkent jondkent deleted the refactor-command-args branch December 2, 2019 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdullahgarcia abdullahgarcia abdullahgarcia approved these changes

@s-irvine s-irvine Awaiting requested review from s-irvine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jondkent @abdullahgarcia