-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix/wake vortex #80
Conversation
@zebengberg You might need to update the .json files in the unit testing of CoCiP outputs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Roger! I've reviewed, and it looks good. Thanks for the documentation improvements.
I'll add the new reference to the bibliography on Zotero and make the citation.
@zebengberg I'll merge this into main once I'm done.
Great work @roger-teoh! @mlshapiro: can you also update the changelog? If the static cocip test files need to be significantly updated, I think you should cut a new release (v0.45.1). |
…test tests/unit --regenerate-results). Add Makefile receipe to run tests and regenerate results
Closes #XX
Changes
Address unit inconsistency in
turbulent_kinetic_energy_dissipation_rate function
as identified by Wessel99, and updatewake_vortex.py
Breaking changes
Features
Fixes
turbulent_kinetic_energy_dissipation_rate
inwake_vortex.py
wake_vortex.py
wake_vortex.py
by removing "get" at the start of each function.Internals
Tests
make test
)Reviewer