Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/shift longitude reverse #105

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Feature/shift longitude reverse #105

merged 3 commits into from
Oct 31, 2023

Conversation

mlshapiro
Copy link
Contributor

@mlshapiro mlshapiro commented Oct 27, 2023 •
edited
Loading

Changes

This is a tiny old branch for a small utility function. I added some test so we make sure to get this into the library.

Breaking changes

Features

  • Adds met.shift_longitude_reverse function to translate longitude coordinates from [180, 180) -> [0, 360) domain

Fixes

Internals

Tests

  • QC test passes locally (make test)
  • CI tests pass

Reviewer

@mlshapiro mlshapiro requested a review from zebengberg October 27, 2023 01:38
zebengberg
zebengberg approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@zebengberg zebengberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks expanding our unit tests! Feel free ignore any of my suggestions.

pycontrails/core/met.py Outdated Show resolved Hide resolved
pycontrails/core/met.py Outdated Show resolved Hide resolved
tests/unit/test_met.py Outdated Show resolved Hide resolved
pycontrails/core/met.py Outdated Show resolved Hide resolved
@mlshapiro mlshapiro force-pushed the feature/shift-longitude-reverse branch from 8e1f8d9 to 4e7fbf3 Compare October 31, 2023 17:34
@mlshapiro mlshapiro merged commit 4e7fbf3 into main Oct 31, 2023
9 checks passed
@mlshapiro mlshapiro deleted the feature/shift-longitude-reverse branch October 31, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zebengberg zebengberg zebengberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlshapiro @zebengberg