Skip to content

Commit

Permalink
relax tolerance passed into newton's method
Browse files Browse the repository at this point in the history
  • Loading branch information
zebengberg committed Dec 12, 2024
1 parent 898c5fb commit 5303cba
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
- Change the order of advected points returned by `DryAdvection` to be consistent with the input order at each time step.
- Add the `RUF` ruleset for linting and formatting the codebase.
- Update type hints for `numpy` 2.2 compatibility. Additional changes may be required after the next iteration of the `numpy` 2.2 series.
- Relax the tolerance passed into `scipy.optimize.newton` in `ps_nominal_grid` to avoid more convergence warnings. These warnings were more distracting than informative.

## v0.54.3

Expand Down
2 changes: 1 addition & 1 deletion pycontrails/models/ps_model/ps_grid.py
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ def ps_nominal_grid(
func=_newton_func,
args=(perf,),
x0=x0,
tol=1.0,
tol=80.0, # use roughly the weight of a passenger as a tolerance
disp=False,
maxiter=maxiter,
)
Expand Down

0 comments on commit 5303cba

Please sign in to comment.