Skip to content
This repository has been archived by the owner on Dec 4, 2018. It is now read-only.

Created the keep-old-app flag #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adamsiemion
Copy link

@adamsiemion adamsiemion commented Jul 26, 2018

I have created a new arg flag keep-old-app, which skips deleting of the old app.

This was required by the project which currently work on.
We use Pivotal Cloud Foundry (PCF) container-to-container networking and Eureka service registry.

The way we use autopilot is the following (let's assume the service we are redeploying is called test-service:

  • Eureka has our test-service already registered
  • we run zero-downtime-push with -keep-old-app
  • test-service (the new app) and test-service-venerable (the old app) are both running, but the new app is not registered in Eureka because it cannot establish a connection to Eureka due to the missing c2c policies therefore all the requests are still routed to the old service
  • we run a script to set up the c2c policies
  • now since the new app is able to establish a connection to Eureka it can register itself
  • after some time, we run cf delete test-service-venerable to remove the old app

@mibollma
Copy link

mibollma commented Jul 27, 2018

I would find it more useful to change the flag to an enumeration e.g.
-old-app=remove|stop|none where remove is the default, none solves your case and stop solves my case #53.
What do you think?

I'm willing to help, unfortunately new to the language go.

@adamsiemion
Copy link
Author

@mibollma Good work on the code changes! I support the idea. Actually recently we have moved away from this plugin to the tool that does the same thing but just calls cf with appropriate commands (https://github.com/adamsiemion/pcf-zerodowntimedeploy). The main reason is the fact that we use plugins for Cloud Foundry in Jenkins and Urban Code Deploy, which only support the push command and does not allow to use zero-downtime-push instead.

@mibollma
Copy link

mibollma commented Aug 8, 2018

@adamsiemion Thanks for your support. Hopefully @xoebus will find the time to take a look.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants