Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmark and std::simd #91

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Add benchmark and std::simd #91

merged 1 commit into from
Feb 24, 2024

Conversation

Yaraslaut
Copy link
Member

Added benchmark based on google benchmark and std::simd usage for gcc

@github-actions github-actions bot added the CMake label Feb 14, 2024
@Yaraslaut Yaraslaut force-pushed the improvement/add_benchmark_and_std_simd branch from f7a45fe to 812b427 Compare February 14, 2024 17:53
christianparpart
christianparpart requested changes Feb 15, 2024
View reviewed changes
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should check that like this rather than hard-checking on compiler names. __has_include is supposed since C++17, so it should have it always. Not sure every stdlib will have <experimental/simd> where we're getting compiled on. :)

src/libunicode/scan.cpp Outdated Show resolved Hide resolved
@christianparpart
Copy link
Member

forgot to mention, going for __has_include also enables us to automatically build on Windows/MSVC once they have it. :)

@Yaraslaut Yaraslaut force-pushed the improvement/add_benchmark_and_std_simd branch 2 times, most recently from 1f53206 to 14b879a Compare February 15, 2024 21:21
@github-actions github-actions bot added the CI label Feb 15, 2024
@Yaraslaut Yaraslaut force-pushed the improvement/add_benchmark_and_std_simd branch 4 times, most recently from 5cc0774 to 8061983 Compare February 15, 2024 21:37
@christianparpart christianparpart force-pushed the improvement/add_benchmark_and_std_simd branch from 8061983 to 91c51a0 Compare February 21, 2024 22:16
@Yaraslaut Yaraslaut force-pushed the improvement/add_benchmark_and_std_simd branch from 91c51a0 to 805a226 Compare February 22, 2024 08:37
@Yaraslaut Yaraslaut marked this pull request as ready for review February 22, 2024 08:37
@Yaraslaut Yaraslaut force-pushed the improvement/add_benchmark_and_std_simd branch from 805a226 to b127a8a Compare February 22, 2024 08:38
@Yaraslaut
Add benchmark and std::simd
ad31aa4 
Signed-off-by: Christian Parpart <[email protected]>
@Yaraslaut Yaraslaut force-pushed the improvement/add_benchmark_and_std_simd branch from b127a8a to ad31aa4 Compare February 22, 2024 18:02
@christianparpart christianparpart merged commit a051446 into master Feb 24, 2024
14 of 17 checks passed
@christianparpart christianparpart deleted the improvement/add_benchmark_and_std_simd branch February 24, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianparpart christianparpart christianparpart requested changes

Assignees
No one assigned
Labels
CI CMake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yaraslaut @christianparpart