Use std::format() API now, instead of fmtlib #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianparpart
force-pushed
the
stdlib
branch
2 times, most recently
from
05a4473
to
df2ccfb
Compare
christianparpart
force-pushed
the
stdlib
branch
5 times, most recently
from
8bf00be
to
e96fbaa
Compare
|
Agree, that we can drop 22.04 |
christianparpart
force-pushed
the
stdlib
branch
from
e96fbaa
to
af627a0
Compare
Yaraslaut
approved these changes
Sep 22, 2024
christianparpart
force-pushed
the
stdlib
branch
from
af627a0
to
6f8e210
Compare
Signed-off-by: Christian Parpart <[email protected]>
christianparpart
force-pushed
the
stdlib
branch
from
6f8e210
to
396729f
Compare
|
Fedora Fedora test due to the use of std::simd. This is unrelated. We're fixing it distinctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Yaraslaut I also dropped Ubuntu 20.04, because we don't support it in Contour anymore anyways. For Ubuntu 22.04 I needed to install a newer Clang manually (via llvm.sh), as we at least need Clang 16 to get
<format>header. We should only merge iff we agree with that on the Contour side as well, because there, we currently build with Clang 15 on Ubuntu 22.04, and GCC would break there as well. So do we need to support Ubuntu 22.04 still anyways? I'd rather prefer to drop it, especially since we seek to move to c++23 kind-of-soon, as well. I also don't think that (if added t Ubuntu at some point), it'll most likely not be for any old version anyways.Summary