Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Looped requests cause page crashes #3034

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/protocol/ideWebview.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export type ToWebviewFromIdeProtocol = ToWebviewFromIdeOrCoreProtocol & {
setTheme: [{ theme: any }, void];
setColors: [{ [key: string]: string }, void];
"jetbrains/editorInsetRefresh": [undefined, void];
"jetbrains/isOSREnabled": [boolean, void];
"jetbrains/jcefOSREnabled": [boolean, void];
addApiKey: [undefined, void];
setupLocalConfig: [undefined, void];
incrementFtc: [undefined, void];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import com.intellij.lang.annotation.HighlightSeverity
import com.intellij.notification.NotificationAction
import com.intellij.notification.NotificationGroupManager
import com.intellij.notification.NotificationType
import com.intellij.openapi.Disposable
import com.intellij.openapi.application.ApplicationInfo
import com.intellij.openapi.application.ApplicationManager
import com.intellij.openapi.command.WriteCommandAction
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ class ContinueBrowser(val project: Project, url: String) {
}

"jetbrains/isOSREnabled" -> {
sendToWebview( "jetbrains/isOSREnabled", isOSREnabled)
sendToWebview( "jetbrains/jcefOSREnabled", isOSREnabled)
}

"onLoad" -> {
Expand Down
2 changes: 1 addition & 1 deletion gui/src/hooks/useIsOSREnabled.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export default function useIsOSREnabled() {
const [isOSREnabled, setIsOSREnabled] = useState(false);
const ideMessenger = useContext(IdeMessengerContext);

useWebviewListener("jetbrains/isOSREnabled", async (isOSREnabled) => {
useWebviewListener("jetbrains/jcefOSREnabled", async (isOSREnabled) => {
setIsOSREnabled(isOSREnabled);
});

Expand Down
Loading