-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better history UI #2542
base: dev
Are you sure you want to change the base?
Better history UI #2542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good! Fits with the rest of Continue much better. Here are some other thoughts:
- I still don't understand the "Show All" button. I also always forget that it only shows sessions from my current workspace by default. When I open Continue without a workspace, it then gives me the confusing "No past sessions found" even when I just had some sessions. I need to click "Show All" to reveal them
- I think we should make the "Open New Window" icon smaller to better fit with the other icons in the top right
- I think we should only have one way to go full screen
Agreed, looks really solid! I wouldn't be opposed to just making the history "Show all" by default. Seems sensible. |
Yes, let's go with all by default for now and add more filters later If we don't set size, then I think the padding should be increased around the icon if possible Yes, I think we should pick one and roll with it |
Given we're picking one full screen option, don't worry about the icon sizing (not worth us making a custom image, which is what would be required), just use the one we've previously been using Probably use the |
Summary of the changes:
|
Description
UI improvements
Checklist
dev
, rather thanmain
Screenshots
HOVER STATE:
Testing
[ For new or modified features, provide step-by-step testing instructions to validate the intended behavior of the change. ]