Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

**Fix:** Add size restriction to Hint #992

Merged
merged 5 commits into from
Apr 24, 2019
Merged

**Fix:** Add size restriction to Hint #992

merged 5 commits into from
Apr 24, 2019

Conversation

TejasQ
Copy link
Contributor

@TejasQ TejasQ commented Apr 24, 2019

This PR fixes #989 and makes Hint a little more accessible.

@TejasQ TejasQ requested a review from fabien0102 April 24, 2019 09:10
@TejasQ TejasQ self-assigned this Apr 24, 2019
@fabien0102
Copy link
Contributor

No CI anymore over there? 🤔

Copy link
Contributor

@fabien0102 fabien0102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks amazing!

<div>
<span>I shouldn't either</span>
<Hint right tooltipPosition="smart">
<img alt="HUGE IMAGE" src="https://placehold.it/1920x1080" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@@ -117,7 +110,7 @@ export const Container = styled("div")<{
top: 0,
left: -32,
display: "block",
width: -32,
width: 32,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best catch ever ^^

@TejasQ TejasQ merged commit f51be18 into master Apr 24, 2019
@TejasQ TejasQ deleted the fix/#989-hint branch April 24, 2019 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hints can be quite long
2 participants