-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ozzo validation #134
fix: ozzo validation #134
Conversation
OpenAPI required, nullable, min and minLength influence how OZZO validation should be done.
e70ce7f
to
bdf9676
Compare
The linter is failing with an internal error
|
This is fixed now |
Please let me know what else is needed to get it accepted. thanks! |
@injeniero overall it looks good, but I need a bit more time to go through all of the changes and test it out locally, I am aiming that we have this merged no later than end of week |
🤖 I have created a release *beep* *boop* --- ## [2.1.1](v2.1.0...v2.1.1) (2024-02-16) ### Bug Fixes * ozzo validation ([#134](#134)) ([d48b64b](d48b64b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Thanks!!! |
OpenAPI required, nullable, min, max, minLength and maxLength influence how OZZO validation should be done.
This changes are in the direction described in the OpenAPI 3.0.3 clarification on how
nullable
property should work.The following table summarize this PR interpretation of the spec on how it should be done using ozzo validations.
How Has This Been Verified?
I run it against our live service code and also checked each generated test case.
Checklist: