Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue with variant revert dropdown in canvas #317

Merged
merged 3 commits into from
Jan 8, 2025
Merged

fix: issue with variant revert dropdown in canvas #317

merged 3 commits into from
Jan 8, 2025

Conversation

srinad007
Copy link
Contributor

  1. for multiple fields show variant icon instead of dropdown
  2. fix variant revert dropdown not closing on clicking again

@srinad007 srinad007 requested a review from a team as a code owner January 6, 2025 11:49
@srinad007 srinad007 requested review from hiteshshetty-dev, faraazb and sairajchouhan and removed request for a team January 6, 2025 11:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 49.43% 6351 / 12846
🔵 Statements 49.43% 6351 / 12846
🔵 Functions 73.11% 223 / 305
🔵 Branches 82.39% 674 / 818
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/visualBuilder/visualBuilder.style.ts 100% 100% 100% 100%
src/visualBuilder/components/FieldToolbar.tsx 78.37% 67.56% 35.71% 78.37% 55-109, 145-146, 157, 174, 176-177, 202-205, 227-236, 258-259, 266-267, 270-271, 321-327, 391, 423
src/visualBuilder/components/FieldRevert/FieldRevertComponent.tsx 98.93% 94.11% 100% 98.93% 59-60
src/visualBuilder/components/FieldRevert/useHandleOutsideClick.ts 100% 100% 100% 100%
src/visualBuilder/components/icons/variant.tsx 100% 100% 100% 100%
Generated in workflow #172 for commit 11c9b8b by the Vitest Coverage Report Action

hiteshshetty-dev
hiteshshetty-dev approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@hiteshshetty-dev hiteshshetty-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@srinad007 srinad007 merged commit cb2e291 into develop_v3 Jan 8, 2025
7 checks passed
@KANE-99 KANE-99 mentioned this pull request Jan 10, 2025
Merged
@aravindbuilt aravindbuilt deleted the VE-4792 branch January 15, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiteshshetty-dev hiteshshetty-dev hiteshshetty-dev approved these changes

@faraazb faraazb Awaiting requested review from faraazb

@sairajchouhan sairajchouhan Awaiting requested review from sairajchouhan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srinad007 @hiteshshetty-dev