Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clean up event listeners in FieldToolbar and update query selector #311

Merged
merged 1 commit into from
Dec 17, 2024
Merged

fix: clean up event listeners in FieldToolbar and update query selector #311

merged 1 commit into from
Dec 17, 2024

Conversation

hiteshshetty-dev
Copy link
Contributor

No description provided.

@hiteshshetty-dev hiteshshetty-dev requested a review from a team as a code owner December 17, 2024 09:06
srinad007
srinad007 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@srinad007 srinad007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 47.95% 6117 / 12756
🔵 Statements 47.95% 6117 / 12756
🔵 Functions 71.62% 212 / 296
🔵 Branches 81.56% 646 / 792
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/visualBuilder/components/FieldToolbar.tsx 76.53% 62.16% 35.71% 76.53% 55-109, 144-145, 156, 173, 175-176, 203-206, 228-237, 259-260, 267-268, 271-272, 322-328, 355-361, 391, 423
src/visualBuilder/generators/generateToolbar.tsx 88.34% 62.5% 80% 88.34% 63, 77-80, 97-101, 130-131
src/visualBuilder/utils/handleIndividualFields.ts 72.22% 68.96% 83.33% 72.22% 73, 120, 126-128, 137-143, 160, 173-196, 199-218, 286-294, 308-315
Generated in workflow #160 for commit cdee2a1 by the Vitest Coverage Report Action

@hiteshshetty-dev hiteshshetty-dev merged commit aa7a95e into develop_v3 Dec 17, 2024
8 checks passed
@hiteshshetty-dev hiteshshetty-dev mentioned this pull request Dec 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srinad007 srinad007 srinad007 approved these changes

@faraazb faraazb Awaiting requested review from faraazb

@csAyushDubey csAyushDubey Awaiting requested review from csAyushDubey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiteshshetty-dev @srinad007