Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix remove highlight variant field classes #291

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix remove highlight variant field classes #291

merged 1 commit into from
Nov 11, 2024

Conversation

srinad007
Copy link
Contributor

No description provided.

@srinad007 srinad007 requested a review from a team as a code owner October 31, 2024 11:25
@srinad007 srinad007 requested review from hiteshshetty-dev, sairajchouhan and faraazb and removed request for a team October 31, 2024 11:25
@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 48.29% 6102 / 12635
🔵 Statements 48.29% 6102 / 12635
🔵 Functions 71.57% 209 / 292
🔵 Branches 81.54% 632 / 775
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/visualBuilder/eventManager/useVariantsPostMessageEvent.ts 27.65% 100% 16.66% 27.65% 36-43, 45-57, 59-82, 84-92, 98-99, 104-105, 110-111, 116-121, 126-127
Generated in workflow #131 for commit 0b02a1d by the Vitest Coverage Report Action

faraazb
faraazb approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@faraazb faraazb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

hiteshshetty-dev
hiteshshetty-dev approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@hiteshshetty-dev hiteshshetty-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@srinad007 srinad007 merged commit 5ffee44 into VC-115/live-editor-support Nov 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faraazb faraazb faraazb approved these changes

@hiteshshetty-dev hiteshshetty-dev hiteshshetty-dev approved these changes

@sairajchouhan sairajchouhan Awaiting requested review from sairajchouhan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srinad007 @hiteshshetty-dev @faraazb