Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

card button resizing issue fixed #265

Conversation

jothi-contentstack
Copy link
Collaborator

https://contentstack.atlassian.net/browse/VE-3574
Section Banner & Card Button Resizing Bug - Fixed.

Copy link
Contributor

@hiteshshetty-dev hiteshshetty-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Make sure it doesn't break any existing test cases.
cc @Deepak-Kharah

@hiteshshetty-dev
Copy link
Contributor

@jothi-contentstack Have you tested after adding new blocks how it reposition works?

@hiteshshetty-dev hiteshshetty-dev self-requested a review October 14, 2024 06:46
Copy link
Contributor

@csAyushDubey csAyushDubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, repositioning code can be moved into utils later.

@jothi-contentstack jothi-contentstack merged commit 22f5dbf into VC-115/live-editor-support Oct 16, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants