Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ve 3355 iframe variant revert #252

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Ve 3355 iframe variant revert #252

merged 3 commits into from
Oct 7, 2024

Conversation

amey-shrivastava
Copy link
Contributor

@amey-shrivastava amey-shrivastava requested a review from a team as a code owner September 30, 2024 05:43
@amey-shrivastava amey-shrivastava marked this pull request as draft September 30, 2024 09:09
@amey-shrivastava amey-shrivastava marked this pull request as ready for review September 30, 2024 12:14
hiteshshetty-dev
hiteshshetty-dev approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@hiteshshetty-dev hiteshshetty-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@hiteshshetty-dev hiteshshetty-dev merged commit 7207ef0 into VC-115/live-editor-support Oct 7, 2024
4 of 5 checks passed
@amey-shrivastava amey-shrivastava deleted the VE-3355-iframe-variant-revert-component branch October 7, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiteshshetty-dev hiteshshetty-dev hiteshshetty-dev approved these changes

@faraazb faraazb Awaiting requested review from faraazb

@srinad007 srinad007 Awaiting requested review from srinad007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amey-shrivastava @hiteshshetty-dev