Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/mkt 5594 delete function #267

Merged
merged 4 commits into from
Apr 25, 2024
Merged

Conversation

Amitkanswal
Copy link
Contributor

@Amitkanswal Amitkanswal commented Apr 23, 2024

@Amitkanswal Amitkanswal requested a review from a team as a code owner April 23, 2024 19:35
@Amitkanswal Amitkanswal marked this pull request as draft April 23, 2024 19:35
@Amitkanswal Amitkanswal marked this pull request as ready for review April 24, 2024 14:15
Signed-off-by: Amitkanswal <[email protected]>
@@ -133,38 +142,36 @@ const AudienceModal = (props: any) => {
<div>
<ModalHeader title="Select Audience" closeModal={props.closeModal} />
<ModalBody>
<EmptyStateComponent isConfigured={isConfigured} invalidConfig={invalidConfig}>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why have we removed invalidConfig check ? @Amitkanswal

children: [getNode],
}, { ...audiencePost }]

const newNode1 = audienceWrapper(newNode)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have a better name than newNode1 ? @Amitkanswal

@Amitkanswal Amitkanswal merged commit a76f2be into staging Apr 25, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants