Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next #34

Merged
merged 9 commits into from
Apr 25, 2023
Merged

Next #34

merged 9 commits into from
Apr 25, 2023

Conversation

sunil-lakshman
Copy link
Contributor

@sunil-lakshman sunil-lakshman commented Apr 19, 2023

Ruby - Azure-EU and include_metadata Implementation in Ruby Delivery SDK

Adding Region Support for Azure-EU

Adding support for include_metadata in Asset, Entry and Query classes.

* Feat/cs 37229 azure eu and include metadata

* Added new method for custom host support with different regions
Feat/cs 37229 azure eu and include metadata (#32)
@sunil-lakshman sunil-lakshman requested a review from a team as a code owner April 19, 2023 11:42
@sunil-lakshman sunil-lakshman requested a review from a team April 19, 2023 11:42
@sunil-lakshman sunil-lakshman self-assigned this Apr 19, 2023
Copy link
Member

@ishaileshmishra ishaileshmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have added 2 feature in the code

  • include_metadata
  • Region support for Azure-EU

Test cases added partially for the include_metadata. and there are no testcase added for the region support.

Copy link
Member

@ishaileshmishra ishaileshmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 change : Use Protocol = 'https://'

Copy link
Member

@ishaileshmishra ishaileshmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@ishaileshmishra
Copy link
Member

Conversation is not closed that is why it is blocked to merge. Please resolve all the conversations. @sunil-lakshman

@ishaileshmishra ishaileshmishra merged commit a88f936 into master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants