-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next #34
Next #34
Conversation
* Feat/cs 37229 azure eu and include metadata * Added new method for custom host support with different regions
Feat/cs 37229 azure eu and include metadata (#32)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have added 2 feature in the code
- include_metadata
- Region support for Azure-EU
Test cases added partially for the include_metadata. and there are no testcase added for the region support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 change : Use Protocol = 'https://'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
Conversation is not closed that is why it is blocked to merge. Please resolve all the conversations. @sunil-lakshman |
Ruby - Azure-EU and include_metadata Implementation in Ruby Delivery SDK
Adding Region Support for Azure-EU
Adding support for include_metadata in Asset, Entry and Query classes.