Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify CMS branch using env config #63

Merged
merged 31 commits into from
Mar 14, 2023

Conversation

dhruvparekh12
Copy link
Contributor

@dhruvparekh12 dhruvparekh12 commented Mar 6, 2023

Many a times, users try to deploy the contentstack-nextjs-starter-app on Launch using a delivery token scoped to a Contentstack branch, other than the default main branch. But, the deployments fail with this error

Error: {"error_message":"Access denied. You have insufficient permissions to perform operation on this branch 'main'.","error_code":901}

To fix this, users need to be able to optionally set an environment variable CONTENTSTACK_BRANCH mentioning the name of the branch on Contentstack.
Code changes in this PR will allow users to set CONTENTSTACK_BRANCH environment variable so their deployments can be successful on Launch.

Amitkanswal and others added 30 commits December 17, 2021 15:51
Upgrade all libraries to address all vulnerability concerns
Nextjs SSR starter is not loading on build [ECO-1166]
@dhruvparekh12 dhruvparekh12 requested a review from a team as a code owner March 6, 2023 10:18
@dhruvparekh12 dhruvparekh12 requested a review from a team March 6, 2023 10:18
@dhruvparekh12 dhruvparekh12 changed the title Sepcify CMS branch using env config Specify CMS branch using env config Mar 6, 2023
@dhruvparekh12
Copy link
Contributor Author

Hi @Amitkanswal @surajcontentstack @abhishek305
Can you please review and approve these changes?

@abhishek305 abhishek305 changed the base branch from master to staging March 6, 2023 11:04
@abhishek305
Copy link
Contributor

Hi @dhruvparekh12,
Could you please add a description/changes made giving context?

Note: Changed the base branch to staging

cc @Amitkanswal @surajcontentstack

@dhruvparekh12
Copy link
Contributor Author

dhruvparekh12 commented Mar 6, 2023

Hi @abhishek305

Added description. Also please let me know if any additional information is required.

@dhruvparekh12
Copy link
Contributor Author

Hi team,
Can we merge this?
I do not have permission to merge, can you please complete the merge on this PR?
Thanks

Copy link

@systemsconsciousness systemsconsciousness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing this change, and it is working. -DH

@Amitkanswal Amitkanswal merged commit e199e62 into contentstack:staging Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants