Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ terms support #81

Merged
merged 7 commits into from
Sep 29, 2023
Merged

feat: ✨ terms support #81

merged 7 commits into from
Sep 29, 2023

Conversation

harshithad0703
Copy link
Contributor

No description provided.

@harshithad0703 harshithad0703 requested a review from a team as a code owner September 25, 2023 08:27
@github-actions
Copy link

github-actions bot commented Sep 25, 2023

Coverage report for commit: 6986875
File: coverage/clover.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  10% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  50% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  80% │ █████████████░░░░░░░░░░ │ 22.5%
  90% │ ███████████████████░░░░ │ 35.0%
 100% │ ███████████████████████ │ 42.5%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution 
Summary - Lines: 89.86% | Methods: 97.23% | Branches: 73.33%
FilesLinesMethodsBranches
lib/app/authorization
   index.js91.67%100.00%72.09%
lib/app/hosting
   deployment.js85.29%100.00%65.79%
   index.js80.70%100.00%59.09%
lib/app
   index.js92.78%100.00%66.12%
lib/app/installation
   index.js84.62%100.00%59.55%
lib/app/request
   index.js91.43%100.00%65.85%
lib
   contentstack.js100.00%100.00%100.00%
   contentstackClient.js100.00%100.00%85.00%
   contentstackCollection.js100.00%100.00%100.00%
   entity.js84.94%100.00%60.79%
lib/core
   Util.js96.36%100.00%83.64%
   concurrency-queue.js91.86%93.75%86.32%
   contentstackError.js100.00%100.00%100.00%
   contentstackHTTPClient.js98.00%100.00%93.48%
lib/organization
   index.js83.33%100.00%60.98%
lib/query
   index.js80.43%100.00%67.27%
lib/stack/asset/folders
   index.js100.00%100.00%100.00%
lib/stack/asset
   index.js85.29%84.21%64.94%
lib/stack/auditlog
   index.js95.83%100.00%75.76%
lib/stack/branch
   compare.js81.82%100.00%71.88%
   index.js97.44%100.00%80.56%
   mergeQueue.js100.00%100.00%73.68%
lib/stack/branchAlias
   index.js86.21%100.00%65.85%
lib/stack/contentType/entry
   index.js91.04%100.00%73.77%
lib/stack/contentType
   index.js83.02%85.71%70.18%
lib/stack/deliveryToken
   index.js100.00%100.00%94.44%
lib/stack/environment
   index.js100.00%100.00%100.00%
lib/stack/extension
   index.js95.92%100.00%87.76%
lib/stack/globalField
   index.js94.12%100.00%83.78%
lib/stack
   index.js84.44%87.18%73.16%
lib/stack/label
   index.js100.00%100.00%100.00%
lib/stack/locale
   index.js100.00%100.00%100.00%
lib/stack/release
   index.js91.11%100.00%72.34%
lib/stack/roles
   index.js100.00%100.00%100.00%
lib/stack/taxonomy
   index.js77.78%80.00%60.71%
lib/stack/taxonomy/terms
   index.js92.31%100.00%72.55%
lib/stack/webhook
   index.js89.66%100.00%72.88%
lib/stack/workflow
   index.js89.09%100.00%72.31%
lib/stack/workflow/publishRules
   index.js100.00%100.00%100.00%
lib/user
   index.js94.29%100.00%82.14%

🤖 comment via lucassabreu/comment-coverage-clover

Copy link
Member

@ishaileshmishra ishaileshmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Ensure that it throws an exception if the taxonomy ID is not available when creating a terms instance. It's not worth getting a terms instance if the taxonomy ID is unavailable. @harshithad0703

@nadeem-cs nadeem-cs added the Next label Sep 28, 2023
Copy link
Member

@ishaileshmishra ishaileshmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@harshithad0703 harshithad0703 merged commit 7730b50 into next Sep 29, 2023
7 checks passed
@nadeem-cs nadeem-cs deleted the feat/cs-41463-terms-support branch October 4, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants