Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/dx 87 removing okio txtmark folder #54

Merged
merged 4 commits into from
May 24, 2024
Merged

Fix/dx 87 removing okio txtmark folder #54

merged 4 commits into from
May 24, 2024

Conversation

reeshika-h
Copy link
Contributor

  • removed okio and txtmark folders and added the dependencies in build.gradle

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

We regret to inform you that you are currently not able to merge your changes into the master branch due to restrictions applied by our SRE team. To proceed with merging your changes, we kindly request that you create a pull request from the next branch. Our team will then review the changes and work with you to ensure a successful merge into the master branch.

@abhinav-from-contentstack abhinav-from-contentstack marked this pull request as ready for review May 10, 2024 11:17
@abhinav-from-contentstack abhinav-from-contentstack requested a review from a team as a code owner May 10, 2024 11:17
@harshithad0703 harshithad0703 dismissed abhinav-from-contentstack’s stale review May 13, 2024 12:20

The merge-base changed after approval.

@harshithad0703 harshithad0703 marked this pull request as draft May 14, 2024 07:12
@github-actions GitHub Actions
Copy link

We regret to inform you that you are currently not able to merge your changes into the master branch due to restrictions applied by our SRE team. To proceed with merging your changes, we kindly request that you create a pull request from the next branch. Our team will then review the changes and work with you to ensure a successful merge into the master branch.

@github-actions GitHub Actions
Copy link

We regret to inform you that you are currently not able to merge your changes into the master branch due to restrictions applied by our SRE team. To proceed with merging your changes, we kindly request that you create a pull request from the next branch. Our team will then review the changes and work with you to ensure a successful merge into the master branch.

@abhinav-from-contentstack abhinav-from-contentstack marked this pull request as ready for review May 24, 2024 07:01
sunil-lakshman
sunil-lakshman approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@sunil-lakshman sunil-lakshman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@cs-raj cs-raj merged commit 631338a into master May 24, 2024
6 of 7 checks passed
@reeshika-h reeshika-h deleted the fix/DX-87-removing-okio-txtmark-folder branch July 29, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunil-lakshman sunil-lakshman sunil-lakshman approved these changes

@dhavaljain999 dhavaljain999 dhavaljain999 approved these changes

@abhinav-from-contentstack abhinav-from-contentstack abhinav-from-contentstack left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@reeshika-h @dhavaljain999 @abhinav-from-contentstack @sunil-lakshman @cs-raj @aravindbuilt