-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/DX-648 implemented a warning message if user is using older version of cli #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
naman-contentstack
commented
Nov 21, 2024
•
edited
Loading
edited
- Updated the CLI version 1.31.0 -> 1.32.0
- Added a pre run hook to check if the user is using the latest version of the CLI.
- Will be checking with NPM registry if a new version is out every 3 days.
- Currently warning only once a day and it will reset at midnight.
naman-contentstack
requested review from
shafeeqd959,
netrajpatel,
cs-raj and
aman19K
November 21, 2024 06:57
aman19K
reviewed
Nov 21, 2024
packages/contentstack/src/hooks/prerun/latest-version-warning.ts
Outdated
Show resolved
Hide resolved
aman19K
reviewed
Nov 21, 2024
packages/contentstack/src/hooks/prerun/latest-version-warning.ts
Outdated
Show resolved
Hide resolved
aman19K
reviewed
Nov 21, 2024
aman19K
reviewed
Nov 21, 2024
aman19K
reviewed
Nov 21, 2024
packages/contentstack/src/hooks/prerun/latest-version-warning.ts
Outdated
Show resolved
Hide resolved
@naman-contentstack , LGTM |
aman19K
previously approved these changes
Nov 21, 2024
aman19K
reviewed
Nov 21, 2024
packages/contentstack/src/hooks/prerun/latest-version-warning.ts
Outdated
Show resolved
Hide resolved
netrajpatel
previously approved these changes
Nov 21, 2024
cs-raj
previously approved these changes
Nov 21, 2024
naman-contentstack
dismissed stale reviews from cs-raj, netrajpatel, and aman19K
via
November 21, 2024 09:59
a7a4abe
cs-raj
previously approved these changes
Nov 21, 2024
shafeeqd959
reviewed
Nov 21, 2024
shafeeqd959
reviewed
Nov 22, 2024
cs-raj
previously approved these changes
Nov 22, 2024
cs-raj
approved these changes
Nov 22, 2024
shafeeqd959
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.