Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dx | 1343 config plugin test cases #1607

Merged
merged 5 commits into from
Oct 7, 2024
Merged

dx | 1343 config plugin test cases #1607

merged 5 commits into from
Oct 7, 2024

Conversation

harshithad0703
Copy link
Contributor

  • updated current test cases according to oclif changes
  • added few test cases to improve code coverage reports

@harshithad0703 harshithad0703 requested a review from a team as a code owner October 7, 2024 08:59
sunil-lakshman
sunil-lakshman approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@sunil-lakshman sunil-lakshman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

cs-raj
cs-raj reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@cs-raj cs-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @harshithad0703 one test case is failing
Early access header command
Get early access header: with all flags, should be successful:

@harshithad0703
Copy link
Contributor Author

Hi @harshithad0703 one test case is failing Early access header command Get early access header: with all flags, should be successful:

Working properly

@harshithad0703 harshithad0703 marked this pull request as draft October 7, 2024 13:42
@harshithad0703 harshithad0703 marked this pull request as ready for review October 7, 2024 13:44
@harshithad0703 harshithad0703 merged commit 695e30e into fix-oclif-test-cases Oct 7, 2024
6 checks passed
@harshithad0703 harshithad0703 deleted the test/dx-1343-config-plugin-test-cases branch October 7, 2024 14:48
cs-raj pushed a commit that referenced this pull request Oct 8, 2024
@harshithad0703
Merge pull request #1607 from contentstack/test/dx-1343-config-plugin…
7a0b992 
…-test-cases

dx | 1343 config plugin test cases
cs-raj pushed a commit that referenced this pull request Oct 29, 2024
@harshithad0703
Merge pull request #1607 from contentstack/test/dx-1343-config-plugin…
fdcddc2 
…-test-cases

dx | 1343 config plugin test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aman19K aman19K aman19K approved these changes

@cs-raj cs-raj cs-raj approved these changes

@sunil-lakshman sunil-lakshman sunil-lakshman approved these changes

@shafeeqd959 shafeeqd959 Awaiting requested review from shafeeqd959

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harshithad0703 @sunil-lakshman @cs-raj @aman19K