Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dx | 1203 test cases rate limit command #1565

Conversation

harshithad0703
Copy link
Contributor

  • Set rate limit command test case
  • Get rate limit command test case
  • Remove rate limit command test case

@harshithad0703 harshithad0703 requested a review from a team as a code owner September 12, 2024 12:16
@harshithad0703 harshithad0703 changed the title Test/dx 1203 test cases rate limit command dx | 1203 test cases rate limit command Sep 12, 2024
Copy link
Contributor

@aman19K aman19K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshithad0703 , can you pls check the coverage report & add the test cases?
rate-limit-handler.ts | 10.34 | 0 | 0 | 11.11 | 8-49
rate-limit.ts | 92.85 | 50 | 100 | 91.66 | 37

@harshithad0703 harshithad0703 marked this pull request as draft September 12, 2024 16:58
@harshithad0703 harshithad0703 marked this pull request as ready for review September 13, 2024 09:19
@harshithad0703
Copy link
Contributor Author

Development branch changes needs to be merged once the workflow issue is resolved

@harshithad0703 harshithad0703 merged commit fb1078f into feat/config-rate-limit Sep 13, 2024
3 of 4 checks passed
@harshithad0703 harshithad0703 deleted the test/dx-1203-test-cases-rate-limit-command branch September 13, 2024 12:49
cs-raj pushed a commit that referenced this pull request Oct 8, 2024
…te-limit-command

dx | 1203 test cases rate limit command
cs-raj pushed a commit that referenced this pull request Nov 11, 2024
…te-limit-command

dx | 1203 test cases rate limit command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants