Feat/import overwrite base #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed entry overwrite issues
shafeeqd959
requested review from
antonyagustine,
abhinav-from-contentstack,
netrajpatel and
aman19K
netrajpatel
previously approved these changes
Oct 18, 2023
abhinav-from-contentstack
previously approved these changes
Oct 18, 2023
shafeeqd959
dismissed stale reviews from abhinav-from-contentstack and netrajpatel
via
7e3c753
abhinav-from-contentstack
approved these changes
Oct 18, 2023
| log(this.importConfig, formatError(error), 'info'); | ||
| } else { | ||
| log(this.importConfig, `Language '${code}' failed to import`, 'error'); | ||
| log(this.importConfig, formatError(error), 'error'); |
There was a problem hiding this comment.
@shafeeqd959 Even this line looks like same in both the if and else blocks except the print type (info/error). BTW, Why is the error printed as info.?
antonyagustine
pushed a commit
that referenced
this pull request
Feb 8, 2024
Feat/import overwrite base
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import overwrite feature
Bumped versions
import - 1.10.0, clone - 1.6.0, bootstrap - 1.6.0, seed - 1.6.0, contentstack - 1.10.0