Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default modal configuration #62

Merged
merged 9 commits into from
Apr 11, 2023

Conversation

Deepak-Kharah
Copy link
Contributor

@Deepak-Kharah Deepak-Kharah commented Apr 5, 2023

Tasks

  • Set window.iframeRef to the window.document.body
  • Set window.postRobot to postRobot
  • Add Modal module with .setBackgroundElement() method

QA

Unit test cases have been added to test the following cases

  • Extension object
    • should have a modal property
    • should add body to iframeRef if the user has not provided one
    • should not add body to iframeRef if the user has provided one
  • Modal object
    • should add the first child of the body to iframeRef if the user has not provided one
    • should not add anything to iframeRef if it already exists.
    • should set iframeRef to the element provided by the user.
    • should have a modal property

fixes: https://contentstack.atlassian.net/browse/CS-26933

It contains method to set background modal element.
Here are the list of test cases:
- should add first child of the body to iframeRef if the user has not provided one
- should not add anything to iframeRef if it already exists.
- should set iframeRef to the element provided by the user.
- should have a modal property
@Deepak-Kharah Deepak-Kharah merged commit 1aec861 into develop Apr 11, 2023
@Deepak-Kharah Deepak-Kharah deleted the CS-26933/default-modal-config branch July 21, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants