Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Content type sidebar UI location #132

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

praveen-mohan-cs
Copy link
Contributor

No description provided.

@praveen-mohan-cs praveen-mohan-cs requested a review from a team as a code owner October 21, 2024 10:28
src/ContentTypeSidebarWidget.ts Show resolved Hide resolved
src/uiLocation.ts Outdated Show resolved Hide resolved
@praveen-mohan-cs praveen-mohan-cs changed the base branch from main to staging October 24, 2024 12:04
@praveen-mohan-cs
Copy link
Contributor Author

praveen-mohan-cs commented Oct 24, 2024

@rijil-tr Addressed your comments. I have also changed the base branch to staging. Can you please take a look once and approve ?

Copy link
Contributor

@abhishek305 abhishek305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@praveen-mohan-cs minor comments . rest looks good

src/ContentTypeSidebarWidget.ts Show resolved Hide resolved
src/ContentTypeSidebarWidget.ts Outdated Show resolved Hide resolved
src/ContentTypeSidebarWidget.ts Show resolved Hide resolved
Copy link

@rijil-tr rijil-tr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@praveen-mohan-cs praveen-mohan-cs merged commit ee18192 into staging Oct 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants