Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breadcrumbs tablet view #1427

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

fkaminski
Copy link
Contributor

@fkaminski fkaminski commented Aug 15, 2024

The "Diese Seite bearbeiten" (only DE) causes the following display in tablet view.

image

If we would shorten the text it fits again.

image

@fritzmg
Copy link
Contributor

fritzmg commented Aug 15, 2024

Would the same issue occur if you go one level deeper?

@fkaminski
Copy link
Contributor Author

fkaminski commented Aug 15, 2024

Would the same issue occur if you go one level deeper?

Yepp (even though the breadcrumbs shortens "...").

image

Even then its fits with the fix.

image

@fkaminski
Copy link
Contributor Author

fkaminski commented Aug 16, 2024

Alternatively we could change the media query ?
from:

@media only all and (max-width: 47.938em) {
  #breadcrumbs .links, #top-github-link-text {
      display: none;
  }
}

to: (symbol only)

@media only all and (max-width: 47.938em) {
  #breadcrumbs .links {
      display: none;
  }
}

@media only all and (max-width: 64em) {
  #top-github-link-text {
      display: none;
  }
}

@fritzmg
Copy link
Contributor

fritzmg commented Aug 16, 2024

I am fine with changing the wording of the link. However, it does not solve the problem completely. The issue is that the theme uses float left/right for these things - instead of flex or grid for example.

Copy link
Member

@netzarbeiter netzarbeiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Franko

@netzarbeiter netzarbeiter merged commit 579cc53 into contao:main Aug 16, 2024
@fkaminski fkaminski deleted the pr_breadcrumbs_fix branch August 16, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants