This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[RFC] Remove UTF-8 BOM of files before combining them #8689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ausi
changed the title
leofeyer
approved these changes
Apr 18, 2017
leofeyer
pushed a commit
that referenced
this pull request
Apr 18, 2017
leofeyer
pushed a commit
that referenced
this pull request
Apr 20, 2017
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Apr 25, 2017
# Contao calendar bundle change log ### 4.3.8 (2017-04-24) * Correctly use the en dash in the calendar modules (see contao/core#8690). * Correctly support 64 character template names everywhere (see contao/core#6819). # Contao comments bundle change log ### 4.3.8 (2017-04-24) * Correctly support 64 character template names everywhere (see contao/core#6819). # Contao core bundle change log ### 4.3.9 (2017-04-25) * Revert the Punycode library changes (see contao/core#8693). ### 4.3.8 (2017-04-24) * Inline small images in protected folders in the file manager (see #636). * Correctly encode the URL in the DataContainer::switchToEdit() method (see #762). * Fix the parent view drag and drop in Firefox (see #666). * Correctly display the search results in the extended tree view (see #739). * Update the Punycode library to version 2 (see #748). * Fix the "delete file" button for non-admin users (see #764). * Prevent endless loops in the book navigation module (see contao/core#8665). * Limit the maximum size of dimensionless SVGs in the back end (see contao/core#8684). * Correctly support 64 character template names everywhere (see contao/core#6819). * Remove the UTF-8 BOM when combining files (see contao/core#8689). * Correctly move folders with an "@" in their name (see contao/core#8674). * Correctly redirect to the last page visited upon login (see contao/core#8632). ### 4.3.7 (2017-03-23) * Check the database connection in the WebsiteRootsConfigProvider class. * Fix the %2B conversion in the Controller::addToUrl() method. # Contao listing bundle change log ### 4.3.8 (2017-04-24) * Correctly support 64 character template names everywhere (see contao/core#6819). # Contao news bundle change log ### 4.3.8 (2017-04-24) * Correctly support 64 character template names everywhere (see contao/core#6819). # Contao newsletter bundle change log ### 4.3.8 (2017-04-24) * Correctly support 64 character template names everywhere (see contao/core#6819).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to answer the question “Why does the first rule of this CSS file get ignored” about a thousand times now. So I think it’s better to fix this in the
Combiner:)Steps to reproduce:
body { background: red }and save it as UTF-8 with BOMAfter that the CSS rule does not get applied because the CSS Parser reads it as
[UTF-8 BOM]body { background: red }and[UTF-8 BOM]bodyis not a valid selector.