This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Always apply the IE security fix in the Environment class #7453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply the IE security fix to both Environment::get('queryString') and Environment::get('requestUri') and use Environment::get('queryString') instead of $_SERVER['QUERY_STRING'].
|
@contao/developers Please review. |
|
LGTM |
|
👍 |
1 similar comment
|
👍 |
|
|
||
| // Do not urldecode() here (thanks to Russ McRee)! | ||
| return $strRequest; | ||
| return preg_replace('/^' . preg_quote(TL_PATH, '/') . '\/?/', '', static::get('requestUri')); |
There was a problem hiding this comment.
Sollte man hier nicht ggf. direkt static::requestUri() callen?
There was a problem hiding this comment.
Überall sonst wird auch mit static::get() gearbeitet. Vermutlich, damit der Class-Cache greift.
There was a problem hiding this comment.
Achso okay, daran hab ich net gedacht ^^ dann Feuer frei!
|
Bis auf eine kleine Anmerkung sieht das gut aus 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the IE security fix to both Environment::get('queryString') and Environment::get('requestUri') and use Environment::get('queryString') instead of $_SERVER['QUERY_STRING'].