Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

[3.4-dev] Don't resize uploaded SVG images #7435

Closed

Conversation

ausi
Copy link
Member

@ausi ausi commented Nov 12, 2014

Resizing SVG images doesn't reduce the file size, so they shouldn't be resized on upload.

@leofeyer
Copy link
Member

Resizing during upload is not about file size. It is about file dimensions, so uploaded images won't break your page layout.

@ausi
Copy link
Member Author

ausi commented Nov 12, 2014

Didn't know that. Than we should ignore gdMaxImgWidth and gdMaxImgHeight for SVG images.

@leofeyer
Copy link
Member

Are we not ignoring it already? Then we definitely should :)

@ausi
Copy link
Member Author

ausi commented Nov 12, 2014

Resizing during upload is not about file size. It is about file dimensions, so uploaded images won't break your page layout.

Isn't that what „Maximum front end width“ (maxImageWidth) is for?

@leofeyer
Copy link
Member

Yes, well kind of. Apparently, people needed both :)

@leofeyer leofeyer closed this Nov 25, 2014
@ausi
Copy link
Member Author

ausi commented Nov 25, 2014

@leofeyer I based this PR upon the release/3.4.0 branch hence it got automatically closed now.

@leofeyer leofeyer added this to the 3.4.1 milestone Nov 25, 2014
@leofeyer
Copy link
Member

I'm sorry, I must have missed this PR :( I have created a reminder in #7479.

@leofeyer
Copy link
Member

Still, I don't see anything wrong with resizing SVG images which exceed the limits?

@ausi
Copy link
Member Author

ausi commented Nov 25, 2014

At least gdMaxImgWidth and gdMaxImgHeight should be ignored for SVG images.

@leofeyer
Copy link
Member

Fixed in 765888f.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants