Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Do not redirect a frontend member to a protected page after logout #6210

Closed

Conversation

thkuhn
Copy link

@thkuhn thkuhn commented Sep 20, 2013

'Redirect to last page visited' should redirect to home if last visited page is a protected page.

@Toflar
Copy link
Member

Toflar commented Sep 21, 2013

Would be nice to have that in the page model anyway :)
PageModel::findByLastVisited() ;)

@leofeyer
Copy link
Member

I understand your logic regarding the logout element but not at all regarding the login element. Why would you not want to be redirected to a protected page after login? Isn't the workflow like this:

  • Access a protected page (unauthorized)
  • Be redirected to the login page
  • Be redirect back to the protected page (now authorized)

@leofeyer
Copy link
Member

Implemented in bf3b9b0.

@leofeyer leofeyer closed this Sep 23, 2013
@thkuhn
Copy link
Author

thkuhn commented Sep 23, 2013

"Why would you not want to be redirected to a protected page after login?"

I don't want not to be redirected to a protected page after login. Yes, of course, in many cases I want but that's not the problem.

The login module provides a logout link, if a member is logged in. If the module is placed on a protected page (often in page header or sidebar in a protected website area) and the member visits some protected pages, the 'last_page_visited' is a protected page.
Now using the logout function redirects to a protected page. Thats's the unwanted behaviour.

@leofeyer
Copy link
Member

I see. Adjusted in 78eb2c3.

ralfhartmann pushed a commit to ralfhartmann/core that referenced this pull request Oct 1, 2013
ralfhartmann pushed a commit to ralfhartmann/core that referenced this pull request Oct 2, 2013
ralfhartmann pushed a commit to ralfhartmann/core that referenced this pull request Oct 2, 2013
ralfhartmann pushed a commit to ralfhartmann/core that referenced this pull request Oct 2, 2013
ralfhartmann pushed a commit to ralfhartmann/core that referenced this pull request Oct 2, 2013
ralfhartmann pushed a commit to ralfhartmann/core that referenced this pull request Oct 2, 2013
ralfhartmann pushed a commit to ralfhartmann/core that referenced this pull request Oct 2, 2013
ralfhartmann pushed a commit to ralfhartmann/core that referenced this pull request Oct 2, 2013
ralfhartmann pushed a commit to ralfhartmann/core that referenced this pull request Oct 3, 2013
ralfhartmann pushed a commit to ralfhartmann/core that referenced this pull request Oct 3, 2013
ralfhartmann pushed a commit to ralfhartmann/core that referenced this pull request Oct 3, 2013
ralfhartmann pushed a commit to ralfhartmann/core that referenced this pull request Nov 6, 2013
ralfhartmann pushed a commit to ralfhartmann/core that referenced this pull request Nov 6, 2013
ralfhartmann pushed a commit to ralfhartmann/core that referenced this pull request Nov 6, 2013
ralfhartmann pushed a commit to ralfhartmann/core that referenced this pull request Nov 6, 2013
ralfhartmann pushed a commit to ralfhartmann/core that referenced this pull request Nov 6, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants