Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Missing $this in customizeSearch hook #8841

Closed
Toflar opened this issue Jan 18, 2018 · 1 comment
Closed

Missing $this in customizeSearch hook #8841

Toflar opened this issue Jan 18, 2018 · 1 comment
Assignees
@leofeyer
Labels
defect
Milestone
3.5.33

Comments

@Toflar
Copy link
Member

Toflar commented Jan 18, 2018

https://github.com/contao/core/blob/3.5/system/modules/core/modules/ModuleSearch.php#L130

The hook does not get $this as an argument which I consider to be a bug because you cannot adjust anything depending on the module settings (like $arrPages because you have no idea if a root page was set as reference page or not). To me that's the whole purpose of this hook so that's a bug to me :-)
@leofeyer leofeyer changed the title Missing $this argument in customizeSearch hook rendering it somewhat useless Missing $this in customizeSearch hook Jan 18, 2018
@leofeyer leofeyer added this to the 3.5.33 milestone Jan 18, 2018
@leofeyer leofeyer self-assigned this Jan 19, 2018
leofeyer added a commit that referenced this issue Jan 19, 2018
@leofeyer
Also pass $this in the "customizeSearch" hook (see #8841).
9d7f3d5
leofeyer added a commit to contao/core-bundle that referenced this issue Jan 19, 2018
@leofeyer
Also pass $this in the "customizeSearch" hook (see contao/core#8841).
fe90422
@leofeyer
Copy link
Member

Fixed in 9d7f3d5 and contao/core-bundle@fe90422.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@leofeyer leofeyer

Labels
defect
Projects
None yet
Milestone
3.5.33
Development

No branches or pull requests
2 participants
@Toflar @leofeyer