Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added custom port option for rocketchat #80

Merged
merged 3 commits into from
Nov 15, 2020
Merged

added custom port option for rocketchat #80

merged 3 commits into from
Nov 15, 2020

Conversation

atighineanu
Copy link
Contributor

Closes: #76
Closes: #71
Added custom port option for --url rocketchat://Host:Port/....

@codecov-io
Copy link

codecov-io commented Nov 15, 2020

Codecov Report

Merging #80 (63b2eb2) into master (43ef295) will increase coverage by 0.04%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   56.31%   56.36%   +0.04%     
==========================================
  Files          51       51              
  Lines        1243     1249       +6     
==========================================
+ Hits          700      704       +4     
- Misses        516      518       +2     
  Partials       27       27              
Impacted Files Coverage Δ
pkg/services/rocketchat/rocketchat.go 20.00% <50.00%> (+13.33%) ⬆️
pkg/services/rocketchat/rocketchat_config.go 66.66% <100.00%> (+1.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43ef295...63b2eb2. Read the comment docs.

Copy link
Member

@simskij simskij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition. Thanks for contributing!

Could you please add some tests for this as well? One where Port is set, and one where it's not.

pkg/services/rocketchat/rocketchat.go Outdated Show resolved Hide resolved
Copy link
Member

@simskij simskij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks again for contributing!

@simskij simskij merged commit fcd1e1a into containrrr:master Nov 15, 2020
JonasPf pushed a commit to Blockdaemon/shoutrrr that referenced this pull request Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants