Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate compatibility fixes #136

Merged
merged 3 commits into from
Feb 3, 2021
Merged

Generate compatibility fixes #136

merged 3 commits into from
Feb 3, 2021

Conversation

piksel
Copy link
Member

@piksel piksel commented Feb 3, 2021

Fixes #134
Fixes #135

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #136 (20e9fe6) into main (e19ba77) will decrease coverage by 0.67%.
The diff coverage is 41.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   66.61%   65.93%   -0.68%     
==========================================
  Files          56       56              
  Lines        1339     1371      +32     
==========================================
+ Hits          892      904      +12     
- Misses        368      386      +18     
- Partials       79       81       +2     
Impacted Files Coverage Δ
pkg/services/smtp/smtp_encmethod.go 62.50% <ø> (ø)
pkg/services/telegram/telegram_json.go 100.00% <ø> (ø)
pkg/services/zulip/zulip.go 15.62% <10.00%> (-1.62%) ⬇️
pkg/services/hangouts/hangouts_config.go 36.36% <33.33%> (-63.64%) ⬇️
pkg/services/zulip/zulip_config.go 94.44% <60.00%> (-5.56%) ⬇️
pkg/services/hangouts/hangouts.go 29.62% <80.00%> (+29.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e19ba77...20e9fe6. Read the comment docs.

@piksel piksel merged commit ce75958 into main Feb 3, 2021
@piksel piksel deleted the fix/generate-compat branch February 3, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The generate command carshes for the zulip service The generate command crashes for hangouts service
1 participant