Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support docker secrets for registry password retrieval #67

Merged
merged 1 commit into from
Feb 27, 2022

Conversation

rbauduin
Copy link
Contributor

Signed-off-by: BAUDUIN Raphaël [email protected]

@djmaze
Copy link
Collaborator

djmaze commented Jan 17, 2022

Nice change, thanks!

I think if we allow supplying the password through secrets then we should do the same for the username. @rbauduin Would you be willing to implement that as well?

@djmaze djmaze added this to the 0.7.0 milestone Jan 17, 2022
@rbauduin
Copy link
Contributor Author

I wondered if the usename should also be in a secret, but it seems the docker themselves only bother about the password.
From my understanding hiding usernames is usually related to protecting privacy, phishing attacks of brute force attacks, which don't seem to apply here.
If you think it still has an added value, I would propose to do it in separate pull request

@shizunge

This comment was marked as spam.

@djmaze
Copy link
Collaborator

djmaze commented Feb 27, 2022

Sorry for leaving this lying around for so long. It's good to merge and we can open a separate PR if we want to allow this for the username as well.

@djmaze djmaze merged commit c4ab86c into containrrr:master Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants