Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/system: Test the resource limits #1328

Merged
merged 1 commit into from
Jul 4, 2023
Merged

test/system: Test the resource limits #1328

merged 1 commit into from
Jul 4, 2023

Conversation

debarshiray
Copy link
Member

@debarshiray debarshiray commented Jun 30, 2023 •
edited
Loading

The following caveats must be noted:

  • Podman sets the Toolbx container's soft limit for the maximum number
    of open file descriptors to the host's hard limit, which is often
    greater than the host's soft limit [1].

  • The ulimit(1) options -b, -k, P and -T don't work on Fedora 38
    because the corresponding resource arguments for getrlimit(2) are
    absent from the operating system. These are RLIMIT_SBSIZE,
    RLIMIT_KQUEUES, RLIMIT_NPTS and RLIMIT_PTHREAD respectively.

[1] containers/podman#17681

@debarshiray debarshiray requested a review from HarryMichal as a code owner June 30, 2023 20:00
@debarshiray debarshiray force-pushed the wip/rishi/test-system-ulimit branch from 3d93757 to e5d0874 Compare June 30, 2023 20:02
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/a0ee9d3db5a44dab9e35bbf489121f60

✔️ unit-test SUCCESS in 8m 25s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 19s
✔️ unit-test-restricted SUCCESS in 8m 11s
✔️ system-test-fedora-rawhide SUCCESS in 25m 11s
✔️ system-test-fedora-38 SUCCESS in 24m 53s
✔️ system-test-fedora-37 SUCCESS in 22m 58s

@debarshiray debarshiray force-pushed the wip/rishi/test-system-ulimit branch from e5d0874 to 1249d2d Compare July 1, 2023 06:36
@debarshiray debarshiray changed the title test/system: Test the hard limit for the number of open file descriptors test/system: Test the resource limits Jul 1, 2023
@debarshiray debarshiray force-pushed the wip/rishi/test-system-ulimit branch from 1249d2d to ad37f56 Compare July 1, 2023 06:47
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/083ebe5b957d486c9b882ea5be27ce30

✔️ unit-test SUCCESS in 9m 05s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 00s
✔️ unit-test-restricted SUCCESS in 8m 14s
✔️ system-test-fedora-rawhide SUCCESS in 23m 50s
✔️ system-test-fedora-38 SUCCESS in 24m 53s
✔️ system-test-fedora-37 SUCCESS in 23m 33s

@debarshiray debarshiray force-pushed the wip/rishi/test-system-ulimit branch from ad37f56 to fab2782 Compare July 1, 2023 08:01
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/cd79f60ef3c0402f9dec73c948b59cb5

✔️ unit-test SUCCESS in 8m 47s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 04s
✔️ unit-test-restricted SUCCESS in 8m 10s
✔️ system-test-fedora-rawhide SUCCESS in 26m 17s
✔️ system-test-fedora-38 SUCCESS in 25m 30s
✔️ system-test-fedora-37 SUCCESS in 25m 25s

@debarshiray debarshiray force-pushed the wip/rishi/test-system-ulimit branch from fab2782 to 87b6f8d Compare July 1, 2023 12:06
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/d2538a60239044b388d5b4014c7b7043

✔️ unit-test SUCCESS in 10m 57s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 5m 06s
✔️ unit-test-restricted SUCCESS in 9m 13s
✔️ system-test-fedora-rawhide SUCCESS in 28m 05s
✔️ system-test-fedora-38 SUCCESS in 27m 07s
✔️ system-test-fedora-37 SUCCESS in 26m 34s

@debarshiray debarshiray force-pushed the wip/rishi/test-system-ulimit branch from 87b6f8d to 4dea6b6 Compare July 4, 2023 09:03
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/b4a700998b754a52ad258db4e3643b8e

✔️ unit-test SUCCESS in 9m 53s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 45s
✔️ unit-test-restricted SUCCESS in 9m 12s
✔️ system-test-fedora-rawhide SUCCESS in 26m 34s
✔️ system-test-fedora-38 SUCCESS in 25m 49s
✔️ system-test-fedora-37 SUCCESS in 25m 19s

@debarshiray debarshiray mentioned this pull request Jul 4, 2023
Closed
@debarshiray
test/system: Test the resource limits
569b4df 
The following caveats must be noted:

  * Podman sets the Toolbx container's soft limit for the maximum number
    of open file descriptors to the host's hard limit, which is often
    greater than the host's soft limit [1].

  * The ulimit(1) options -P, -T, -b, and -k don't work on Fedora 38
    because the corresponding resource arguments for getrlimit(2) are
    absent from the operating system.  These are RLIMIT_NPTS,
    RLIMIT_PTHREAD, RLIMIT_SBSIZE and RLIMIT_KQUEUES respectively.

[1] containers/podman#17681

containers#213
@debarshiray debarshiray force-pushed the wip/rishi/test-system-ulimit branch from 4dea6b6 to 569b4df Compare July 4, 2023 13:37
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/07817b1730eb4b6ebbd63fe4ba883c73

✔️ unit-test SUCCESS in 9m 08s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 45s
✔️ unit-test-restricted SUCCESS in 8m 20s
✔️ system-test-fedora-rawhide SUCCESS in 27m 45s
✔️ system-test-fedora-38 SUCCESS in 27m 21s
✔️ system-test-fedora-37 SUCCESS in 26m 35s

@debarshiray debarshiray merged commit 569b4df into containers:main Jul 4, 2023
@debarshiray debarshiray deleted the wip/rishi/test-system-ulimit branch July 4, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarryMichal HarryMichal Awaiting requested review from HarryMichal HarryMichal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@debarshiray