overlay: add detection for overlay support in a user namespace #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
native-overlay
branch
7 times, most recently
from
07c805b
to
8c82e3a
Compare
rhatdan
approved these changes
Mar 4, 2021
|
A couple of nits, but LGTM |
track if if the storage was created using a mount_program. Signed-off-by: Giuseppe Scrivano <[email protected]>
add a public function to check whether the kernel supports native overlay. If the existing storage was created using a mount_program, refuse to use the native overlay as they are not fully compatible, e.g. native overlay uses device whiteout files while a mount_program such as fuse-overlayfs could be using a different format to accomodate older kernels where unprivileged users cannot create whiteout devices. Signed-off-by: Giuseppe Scrivano <[email protected]>
prevent a recursion with the reexec program if the check for native overlay is done in a "init()" function. Signed-off-by: Giuseppe Scrivano <[email protected]>
otherwise it prints all the time with rootless on kernels not supporting native overlay. Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]>
|
One concern with this, is the fix of placing an SELinux label on the context mount, which just got merged into the upstream security kernel. Not in a released kernel yet. I will merge, but we might need to test this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a public function to check whether the kernel supports native overlay.
If the existing storage was created using a mount_program, refuse to use the native overlay as they are not fully compatible, e.g. native overlay uses device whiteout files while a mount_program such as fuse-overlayfs could be using a different format to accomodate older kernels where unprivileged users cannot create whiteout devices.
Users will need the equivalent of "podman system reset" to move to native support.
Signed-off-by: Giuseppe Scrivano [email protected]