Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cri-o-release-1.14] layerStore.Load(): avoid double-locking the mounts list for Save #427

Merged

Conversation

nalind
Copy link
Member

@nalind nalind commented Sep 11, 2019

If we need to re-save the layers list when we've loaded it, to either solve a duplicate name issue or to clean up a partially-constructed layer, don't make the mistake of attempting to take another lock on the mounts list.

Cherry picks #425 for the cri-o-release-1.14 branch.

If we need to re-save the layers list when we've loaded it, to either
solve a duplicate name issue or to clean up a partially-constructed
layer, don't make the mistake of attempting to take another lock on the
mounts list.

Signed-off-by: Nalin Dahyabhai <[email protected]>
Signed-off-by: Nalin Dahyabhai <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Sep 11, 2019

LGTM
@umohnani8 @vrothberg PTAL Not sure why Ubuntu is breaking all the time, this is usually where I whine at @cevich

@umohnani8
Copy link
Member

LGTM

@cevich
Copy link
Member

cevich commented Sep 12, 2019

sigh it's because Ubuntu is simply broken...let me take a peek...

@cevich
Copy link
Member

cevich commented Sep 12, 2019

...sigh, oh this again...yep, it's a broken design.

[+0184s] E: Unable to acquire the dpkg frontend lock (/var/lib/dpkg/lock-frontend), is another process using it?
[+0184s] ##### (failed with exit: 100)
[+0184s] ##### (exceeded 5 attempts)

I believe this is fixed by #408 which is blocked by #419 😞

@cevich
Copy link
Member

cevich commented Sep 12, 2019

I think I see a way to workaround this...will open a PR.

@cevich
Copy link
Member

cevich commented Sep 12, 2019

#428

@rhatdan rhatdan merged commit da6eb54 into containers:cri-o-release-1.14 Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants