Refactor copy of slices and maps #2128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes duplicate copy*Slice functions using a generic copy function or replaces them with the slices.Clone function. Also simplifies the stringSliceWithoutValue function. These changes should not change the behavior. Signed-off-by: Jan Rodák <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Honny1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Honny1
force-pushed
the
refactor-copy-map
branch
from
1b0556c
to
a9ef2aa
Compare
Removes the duplicate copy*Map function using the general function newMapFrom. Reduces the allocation of empty maps using the copyMapPrefferingNil function. This change may affect the behavior so that instead of an empty allocated map, a nil will be returned. Signed-off-by: Jan Rodák <[email protected]>
Honny1
force-pushed
the
refactor-copy-map
branch
from
a9ef2aa
to
13a96fe
Compare
kolyshkin
requested changes
Oct 15, 2024
store.go
Outdated
Comment on lines
1792
to
1768
| options.BigData = copyContainerBigDataOptionSlice(cOptions.BigData) | ||
| options.BigData = slices.Clone(cOptions.BigData) |
There was a problem hiding this comment.
slices.Clone makes a shallow clone, i.e. Data slice is not really copied with this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors:
slices.Clonefunction.stringSliceWithoutValuefunction.newMapFrom.copyMapPrefferingNilfunction.nilwill be returned.Follows up on: #2122