Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overlay to handle mountopt properly #201

Merged
merged 1 commit into from
Jul 25, 2018
Merged

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jul 25, 2018

We need to translate the mount options into flags or
data, so this PR makes the parse code public so we can
use it in containers/storage.

Signed-off-by: Daniel J Walsh [email protected]

@rhatdan
Copy link
Member Author

rhatdan commented Jul 25, 2018

@nalind @giuseppe PTAL

@nalind
Copy link
Member

nalind commented Jul 25, 2018

LGTM pending CI.

We need to translate the mount options into flags or
data, so this PR makes the parse code public so we can
use it in containers/storage.

Signed-off-by: Daniel J Walsh <[email protected]>
@giuseppe
Copy link
Member

LGTM

Copy link
Contributor

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan rhatdan merged commit afdedba into containers:master Jul 25, 2018
@runcom runcom mentioned this pull request Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants